Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: trim and document assumptions for GetQuorum, Get*MN* and friends #6132

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

refactor: trim and document assumptions for GetQuorum, Get*MN* and friends #6132

wants to merge 2 commits into from

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Jul 19, 2024

Additional Information

Work in progress

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 21.1 milestone Jul 19, 2024
@kwvg kwvg requested a review from UdjinM6 July 19, 2024 17:22
PastaPastaPasta
PastaPastaPasta reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems good to me; please apply clang-format :)

kwvg added 2 commits July 26, 2024 10:10
@kwvg
refactor: trim and document assumptions for GetQuorum and friends
8297c8f 
Some portions of the codebase make implicit assumptions that `GetQuorum`
will not return a `nullptr` by not performing checking for it or make
explicit assumptions by `assert`ing not-`nullptr`.

Let's document explicit assumptions, document implicit assumptions and
soften some hard assumptions where softening is possible.
@kwvg
refactor: trim and document assumptions for Get*MN* and friends
d382c05
@UdjinM6 UdjinM6 modified the milestones: 21.1, 21.2 Aug 8, 2024
@PastaPastaPasta
Copy link
Member

Any reason why this has stalled? maybe revive this?

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please rebase.

@kwvg kwvg modified the milestones: 21.2, 22 Oct 9, 2024
@MrDefacto
Copy link

Tested on the mainnet for over two months with no issues so far.

@PastaPastaPasta
Copy link
Member

@kwvg what is the status here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments

@UdjinM6 UdjinM6 Awaiting requested review from UdjinM6

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs rebase
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
4 participants
@kwvg @PastaPastaPasta @MrDefacto @UdjinM6